Compare commits

...

29 Commits

Author SHA1 Message Date
Shefali
a9acebb2bb Merge branch 'master' of https://github.com/nasa/openmct into fix-plots-infinity 2022-09-12 13:35:15 -07:00
Jamie V
eccecfb23f Merge branch 'release/2.0.8' into fix-plots-infinity 2022-08-23 09:38:38 -07:00
Jamie V
5386ceb94c [Time Conductor] History not working correctly (#5687)
* the check for fixed time vs realtime was not updating, have fixed this

* merging in related changes from master pr #4414

* lint fixes

* Update src/plugins/timeConductor/ConductorHistory.vue

Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>

* setting time mode directly on load

* fixing issue where realtime history was being wiped on reloads while viewing fixed time

* formatting

* stubbed in some tests

Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
2022-08-23 09:36:02 -07:00
Jesse Mazzella
affb7a5311 [Docs] Update CouchDB local install documentation (#5692)
* Update local CouchDB install docs to include docker workflow

* reformat to source configuration scripts where possible

* correct couchdb case

Co-authored-by: John Hill <john.c.hill@nasa.gov>
2022-08-23 09:00:04 -07:00
Shefali Joshi
06b321588e Handle couch db not found errors so that interceptors are still invoked. (#5654)
* Fix tests for interceptors
* [e2e] Add test for 'mine' folder initialization
* [e2e] don't fail on expected console errors

Co-authored-by: Andrew Henry <akhenry@gmail.com>
Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
2022-08-22 10:15:52 -07:00
John Hill
909901b0f3 [CI] Enable couchdb e2e testing in open source (#5655) 2022-08-19 13:14:27 -07:00
Charles Hacskaylo
865f95c0b6 Time List 5534 for release/2.0.8 (#5678)
* Changes to Time List view. Closes #5534.
- Compacted table row spacing.
- Set all timeframes to display by default when creating a new Time List.
- Removed 'Upload plan' file button from properties.

* Changes to Time List view. Closes #5534.
- Better hint text for editing Timeframe Inspector section.

Co-authored-by: Andrew Henry <akhenry@gmail.com>
2022-08-19 18:11:30 +00:00
Michael Rogers
cb1e04b0d6 Set Focused Image index after a imagery is selected from a timestrip - 5632 (#5664)
* Set focused image when timestamp prop is passed in

* Unused var

* Create timestrip with imagery child

* Add equality check for hovered image and view large image url

* Cleanup
2022-08-19 17:39:58 +00:00
Shefali Joshi
b0c2e66613 Moves condition set fix into 2.0.8 (#5673) 2022-08-19 15:47:43 +00:00
Andrew Henry
ce15600d25 Merge branch 'release/2.0.8' into fix-plots-infinity 2022-08-18 16:48:17 -07:00
Jesse Mazzella
d162b5dbd8 [e2e] Stabilize notebook tag tests (#5681)
* Use more deterministic selector

* Hover first to "slow down" e2e actions while in headless mode
2022-08-18 21:23:58 +02:00
Jamie V
64565b1bbb [Display Layout] Composition and configuration sync (#5669)
LGTM
2022-08-18 06:52:45 -07:00
Scott Bell
f721980bf0 Mct5549 fix indexer composition error (#5610) 2022-08-18 05:58:54 -07:00
Jesse Mazzella
b47712a0f4 Sort tree items locally on rename (#5643)
* fix typo

* Sort the tree items locally on object rename

* Use the navigationPath as a key

- This ensures that objects AND linked objects will be sorted

* add 'tree' and 'treeitem' roles to mct-tree

* WIP tree item reordering test

* Select the first object that matches

* Test that all object links are also reordered

* Get the final uuid before queryParams as notebook sections have uuids

* Make `openObjectTreeContextMenu` more deterministic and update usage

* Add `expandPathToTreeItem` and `expandTreeItemByName` appActions

* add `#tree-pane` id for the tree view

* Add tree visual component test suite and bump percy-cli

* Remove tree appActions

* Better variable name

Co-authored-by: Scott Bell <scott@traclabs.com>
2022-08-17 18:16:40 +02:00
Jamie V
57f3d4eba0 [Fault Management] New Example Provider, Unit and e2e tests (#5579)
* added unit tests for fault management plugin

* modified the example fault provider to work out of the box

* updating for new e2e folder structure

* part of the e2e tests

* WIP

* Imagery thumbnail regression fixes - 5327 (#5569)

* Add an active class to thumbnail to indicate current focused image

* Differentiate bg color between real-time and fixed

* scrollIntoView inline: center

* Added watcher for bounds change to trigger thumbnail scroll

* Resolve merge conflict with requestHistory change to telemetry collection

* Split thumbnail into sub component

* Monitor isFixed value to unpause playback status

* updated search to include name, namespace and description added some more e2e tests

* added rest of e2e tests

* fixed my init script, had to disable lint for no-force because it was not working without it, saw online this may be a pw bug

* fix: removing maelstrom theme from application (#5600)

* added some tests for no faults

* visual tests

* added visual tests for fault management

* created utils file for shared functionality between function and visual tests

* updating to 2.0.8

* tryin to remove imagery changes from master

* trying to trigger a refresh

* tryin to refresh

* updated search to include name, namespace and description added some more e2e tests

* added rest of e2e tests

* fix: removing maelstrom theme from application (#5600)

* fixed my init script, had to disable lint for no-force because it was not working without it, saw online this may be a pw bug

* added some tests for no faults

* visual tests

* added visual tests for fault management

* created utils file for shared functionality between function and visual tests

* updating to 2.0.8

* no clue

* still no clue

* removing imports and chaning to requires

* updating utils file to work with require

* fixing paths

* fixing a test I had messed up when adding static exmaple faults

* ONE LAST PATH FIX... hopefully

* typo in files fix

* fix folder typo

* thought I got this one, but apparently not, well I did now! who is laughing now!?

Co-authored-by: Michael Rogers <contact@mhrogers.com>
Co-authored-by: Vitor Henckel <vitor@henckel.com.br>
2022-08-15 14:09:23 -07:00
Shefali
5baebc271e Handle infinity as an invalid value 2022-08-12 14:22:53 -07:00
Scott Bell
61bf60783c Prevent cyclic references in link & move actions (#5635)
* do not create circular refs

* add negative validation test

* move to plugin

* add link test too

* fix docs

* refactored per john request

* fix path

* use appAction lib

Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
2022-08-10 19:05:38 +00:00
Shefali
5dc718b78d Update version number 2022-08-10 11:34:12 -07:00
Scott Bell
41f8cb404d Check for circular references in originalPath - 5615 (#5619)
* check for circular references

* add test

* fix test

* address PR comments by making comments better

* fix docs...again
2022-08-09 12:11:03 +02:00
Khalid Adil
c6c58af12c [e2e] Tests for Display Layout and LAD Tables and telemetry (#5607) 2022-08-08 13:30:20 -07:00
Andrew Henry
15a0a87251 Revert "Have in-memory search indexer use composition API (#5578)" (#5609)
This reverts commit 7cf11e177c.
2022-08-04 19:15:54 +00:00
Alize Nguyen
59a8614f1c Add parsing for areIdsEqual util to consistently remove folders (#5589)
* Add parsing util to identifier for ID comparison

* Moved firstIdentifier to top of function

* Lint fix

Co-authored-by: Andrew Henry <akhenry@gmail.com>
2022-08-04 11:42:43 -07:00
Scott Bell
7cf11e177c Have in-memory search indexer use composition API (#5578)
* need to remove tags and objects on composition removal
* had to separate out emits from load as it was causing memory indexer to loop upon itself
2022-08-04 18:20:38 +00:00
Scott Bell
1a44652470 Search should indicate in progress and no results states, filter orphaned results (#5599)
* no matching result implemented

* now filtering annotations that are orphaned

* filter object results without valid paths

* add progress bar

* added e2e tests

* removed extraneous click

* fix typos

* fix unit tests

* lint

* address pr comments

* fix tests

* fix tests, centralize logic to object api, check for root instead

* remove debug statement

* lint

* fix documentation

* lint

* fix doc

* made some optimizations after talking with akhenry

* fix test

* update docs

* fix docs
2022-08-04 11:06:16 -07:00
Andrew Henry
51d16f812a Include the plan source map when generating the time list/plan hybrid object (#5604) 2022-08-03 18:17:16 -07:00
Charles Hacskaylo
25de5653e8 Fix menu style in Snow theme (#5557) 2022-08-03 11:24:04 -07:00
John Hill
cb6014d69f Update package.json (#5601) 2022-08-03 11:12:31 -07:00
Jesse Mazzella
36736eb8a0 [e2e] Improve appActions (#5592)
* update selectors to use aria labels

* Update appActions

- Create new function `getHashUrlToDomainObject` to get the browse url to a given object given its uuid

- Create new function `getFocusedObjectUuid`... self explanatory :)

- Update `createDomainObjectWIthDefaults` to make use of the new url generation

- Update `createDomainObject...`'s arguments to be more organized, and accept a parent object

- Update some docs, still need to clarify some

* Update appActions e2e tests

- Refactor for organization

- Test our new appActions in one go

* Update existing usages of `createDomainObject...` to match the new API

* fix accidental renamed export

* Fix jsdoc return types

* refactor telemetryTable test to use appActions

* Improve selectors

* Refactor test

* improve selector

* add clock mode appActions

* lint

* Fix jsdoc

* Code review comments

* mark failing visual tests as fixme temporarily
2022-08-03 00:48:47 +00:00
Michael Rogers
a13a6002c5 Imagery thumbnail regression fixes - 5327 (#5591)
* Add an active class to thumbnail to indicate current focused image

* Differentiate bg color between real-time and fixed

* scrollIntoView inline: center

* Added watcher for bounds change to trigger thumbnail scroll

* Resolve merge conflict with requestHistory change to telemetry collection

* Split thumbnail into sub component

* Monitor isFixed value to unpause playback status

Co-authored-by: Khalid Adil <khalidadil29@gmail.com>
2022-08-02 13:44:01 -05:00
2 changed files with 12 additions and 3 deletions

View File

@@ -5,7 +5,7 @@
"devDependencies": {
"@babel/eslint-parser": "7.18.9",
"@braintree/sanitize-url": "6.0.0",
"@percy/cli": "1.7.2",
"@percy/cli": "1.8.1",
"@percy/playwright": "1.0.4",
"@playwright/test": "1.25.2",
"@types/eventemitter3": "^1.0.0",

View File

@@ -394,7 +394,8 @@ export default class PlotSeries extends Model {
const currentYVal = this.getYVal(point);
const lastYVal = this.getYVal(data[insertIndex - 1]);
if (this.isValueInvalid(currentYVal) && this.isValueInvalid(lastYVal)) {
if (this.isValueInfinity(currentYVal)
|| (this.isValueInvalid(currentYVal) && this.isValueInvalid(lastYVal))) {
console.warn('[Plot] Invalid Y Values detected');
return;
@@ -423,7 +424,15 @@ export default class PlotSeries extends Model {
* @private
*/
isValueInvalid(val) {
return Number.isNaN(val) || val === undefined;
return this.isValueInfinity(val) || Number.isNaN(val) || val === undefined;
}
/**
*
* @private
*/
isValueInfinity(val) {
return val === Number.POSITIVE_INFINITY || val === Number.NEGATIVE_INFINITY;
}
/**