Merge branch 'master' into eval-source-maps

chore: bump @playwright/test to 1.42.1 (#7627 )
* chore: bump `@playwright/test` to `1.42.1` * chore(circleci): don't try to re-run individual percy tests
2024-03-25 11:12:17 -07:00 · 2024-03-21 09:27:41 -07:00 · 2024-03-20 20:20:48 +00:00 · 2024-03-19 22:57:38 -07:00 · 2024-03-19 20:50:14 -07:00 · 2024-03-15 10:41:14 -07:00
10 changed files with 49 additions and 50 deletions
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -5,18 +5,19 @@ orbs:
 executors:
  pw-focal-development:
    docker:
-      - image: mcr.microsoft.com/playwright:v1.39.0-focal
+      - image: mcr.microsoft.com/playwright:v1.42.1-focal
    environment:
      NODE_ENV: development # Needed to ensure 'dist' folder created and devDependencies installed
-      PERCY_POSTINSTALL_BROWSER: "true" # Needed to store the percy browser in cache deps
-      PERCY_LOGLEVEL: "debug" # Enable DEBUG level logging for Percy (Issue: https://github.com/nasa/openmct/issues/5742)
+      PERCY_POSTINSTALL_BROWSER: 'true' # Needed to store the percy browser in cache deps
+      PERCY_LOGLEVEL: 'debug' # Enable DEBUG level logging for Percy (Issue: https://github.com/nasa/openmct/issues/5742)
+      PERCY_PARALLEL_TOTAL: 2
  ubuntu:
    machine:
      image: ubuntu-2204:current
      docker_layer_caching: true
 commands:
  build_and_install:
-    description: "All steps used to build and install."
+    description: 'All steps used to build and install.'
    parameters:
      node-version:
        type: string
@@ -26,7 +27,7 @@ commands:
          node-version: << parameters.node-version >>
      - node/install-packages
  generate_and_store_version_and_filesystem_artifacts:
-    description: "Track important packages and files"
+    description: 'Track important packages and files'
    steps:
      - run: |
          [[ $EUID -ne 0 ]] && (sudo mkdir -p /tmp/artifacts && sudo chmod 777 /tmp/artifacts) || (mkdir -p /tmp/artifacts && chmod 777 /tmp/artifacts)
@@ -37,7 +38,7 @@ commands:
      - store_artifacts:
          path: /tmp/artifacts/
  generate_e2e_code_cov_report:
-    description: "Generate e2e code coverage artifacts and publish to codecov.io. Needed to that we can ignore the exit code status of the npm run test"
+    description: 'Generate e2e code coverage artifacts and publish to codecov.io. Needed to that we can ignore the exit code status of the npm run test'
    parameters:
      suite:
        type: string
@@ -101,7 +102,7 @@ jobs:
          node-version: lts/hydrogen
      - when: #Only install chrome-beta when running the 'full' suite to save $$$
          condition:
-            equal: ["full", <<parameters.suite>>]
+            equal: ['full', <<parameters.suite>>]
          steps:
            - run: npx playwright install chrome-beta
      - run:
@@ -158,7 +159,7 @@ jobs:
    steps:
      - build_and_install:
          node-version: lts/hydrogen
-      - run: npx playwright@1.39.0 install #Necessary for bare ubuntu machine
+      - run: npx playwright@1.42.1 install #Necessary for bare ubuntu machine
      - run: |
          export $(cat src/plugins/persistence/couch/.env.ci | xargs)
          docker-compose -f src/plugins/persistence/couch/couchdb-compose.yaml up --detach
@@ -220,14 +221,15 @@ jobs:
            equal: [42, 42] # Always run codecov reports regardless of test failure https://discuss.circleci.com/t/make-custom-command-run-always-with-when-always/38957/2
          steps:
            - generate_and_store_version_and_filesystem_artifacts
-  visual-a11y-tests:
+  visual-a11y:
    parameters:
      suite:
        type: string # ci or full
    executor: pw-focal-development
+    parallelism: 2
    steps:
      - build_and_install:
-          node-version: lts/hydrogen
+          node-version: lts/iron
      - run: npm run test:e2e:visual:<<parameters.suite>>
      - store_test_results:
          path: test-results/results.xml
@@ -254,8 +256,8 @@ workflows:
          name: e2e-stable
          suite: stable
      - e2e-mobile
-      - visual-a11y-tests:
-          name: visual-a11y-test-ci
+      - visual-a11y:
+          name: visual-a11y-ci
          suite: ci

  the-nightly: #These jobs do not run on PRs, but against master at night
@@ -274,13 +276,13 @@ workflows:
      - e2e-mobile
      - perf-test
      - mem-test
-      - visual-a11y-tests:
-          name: visual-a11y-test-nightly
+      - visual-a11y:
+          name: visual-a11y-nightly
          suite: full
      - e2e-couchdb
    triggers:
      - schedule:
-          cron: "0 0 * * *"
+          cron: '0 0 * * *'
          filters:
            branches:
              only:
--- a/.github/workflows/e2e-couchdb.yml
+++ b/.github/workflows/e2e-couchdb.yml
@@ -37,7 +37,7 @@ jobs:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}

-      - run: npx playwright@1.39.0 install
+      - run: npx playwright@1.42.1 install

      - name: Start CouchDB Docker Container and Init with Setup Scripts
        run: |
--- a/.github/workflows/e2e-flakefinder.yml
+++ b/.github/workflows/e2e-flakefinder.yml
@@ -30,7 +30,7 @@ jobs:
          restore-keys: |
            ${{ runner.os }}-node-

-      - run: npx playwright@1.39.0 install
+      - run: npx playwright@1.42.1 install
      - run: npm ci --no-audit --progress=false

      - name: Run E2E Tests (Repeated 10 Times)
--- a/.github/workflows/e2e-perf.yml
+++ b/.github/workflows/e2e-perf.yml
@@ -28,7 +28,7 @@ jobs:
          restore-keys: |
            ${{ runner.os }}-node-

-      - run: npx playwright@1.39.0 install
+      - run: npx playwright@1.42.1 install
      - run: npm ci --no-audit --progress=false
      - run: npm run test:perf:localhost
      - run: npm run test:perf:contract
--- a/.github/workflows/e2e-pr.yml
+++ b/.github/workflows/e2e-pr.yml
@@ -33,7 +33,7 @@ jobs:
          restore-keys: |
            ${{ runner.os }}-node-

-      - run: npx playwright@1.39.0 install
+      - run: npx playwright@1.42.1 install
      - run: npx playwright install chrome-beta
      - run: npm ci --no-audit --progress=false
      - run: npm run test:e2e:full -- --max-failures=40
--- a/.webpack/webpack.prod.js
+++ b/.webpack/webpack.prod.js
@@ -15,5 +15,5 @@ export default merge(common, {
      __OPENMCT_ROOT_RELATIVE__: '""'
    })
  ],
-  devtool: 'source-map'
+  devtool: 'eval-source-map'
 });
--- a/e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
+++ b/e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
@@ -292,6 +292,16 @@ test.describe('Basic Condition Set Use', () => {
    await expect(page.getByRole('menuitem', { name: /Conditions View/ })).toBeVisible();
    await expect(page.getByRole('menuitem', { name: /Plot/ })).toBeVisible();
    await expect(page.getByRole('menuitem', { name: /Telemetry Table/ })).toBeVisible();
+    await page.getByLabel('Plot').click();
+    await expect(
+      page.getByLabel('Plot Legend Collapsed').getByText('Test Condition Set')
+    ).toBeVisible();
+    await page.getByLabel('Open the View Switcher Menu').click();
+    await page.getByLabel('Telemetry Table').click();
+    await expect(page.getByRole('searchbox', { name: 'output filter input' })).toBeVisible();
+    await page.getByLabel('Open the View Switcher Menu').click();
+    await page.getByLabel('Conditions View').click();
+    await expect(page.getByText('Current Output')).toBeVisible();
  });
  test('ConditionSet has correct outputs when telemetry is and is not available', async ({
    page
--- a/package-lock.json
+++ b/package-lock.json
@@ -14,14 +14,14 @@
        "@braintree/sanitize-url": "6.0.4",
        "@percy/cli": "1.27.4",
        "@percy/playwright": "1.0.4",
-        "@playwright/test": "1.39.0",
+        "@playwright/test": "1.42.1",
        "@types/d3-axis": "3.0.6",
        "@types/d3-scale": "4.0.8",
        "@types/d3-selection": "3.0.10",
        "@types/d3-shape": "3.0.0",
        "@types/eventemitter3": "1.2.0",
        "@types/jasmine": "5.1.2",
-        "@types/lodash": "4.14.192",
+        "@types/lodash": "4.17.0",
        "@vue/compiler-sfc": "3.4.3",
        "babel-loader": "9.1.0",
        "babel-plugin-istanbul": "6.1.1",
@@ -1548,12 +1548,12 @@
      }
    },
    "node_modules/@playwright/test": {
-      "version": "1.39.0",
-      "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.39.0.tgz",
-      "integrity": "sha512-3u1iFqgzl7zr004bGPYiN/5EZpRUSFddQBra8Rqll5N0/vfpqlP9I9EXqAoGacuAbX6c9Ulg/Cjqglp5VkK6UQ==",
+      "version": "1.42.1",
+      "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.42.1.tgz",
+      "integrity": "sha512-Gq9rmS54mjBL/7/MvBaNOBwbfnh7beHvS6oS4srqXFcQHpQCV1+c8JXWE8VLPyRDhgS3H8x8A7hztqI9VnwrAQ==",
      "dev": true,
      "dependencies": {
-        "playwright": "1.39.0"
+        "playwright": "1.42.1"
      },
      "bin": {
        "playwright": "cli.js"
@@ -1821,9 +1821,9 @@
      "dev": true
    },
    "node_modules/@types/lodash": {
-      "version": "4.14.192",
-      "resolved": "https://registry.npmjs.org/@types/lodash/-/lodash-4.14.192.tgz",
-      "integrity": "sha512-km+Vyn3BYm5ytMO13k9KTp27O75rbQ0NFw+U//g+PX7VZyjCioXaRFisqSIJRECljcTv73G3i6BpglNGHgUQ5A==",
+      "version": "4.17.0",
+      "resolved": "https://registry.npmjs.org/@types/lodash/-/lodash-4.17.0.tgz",
+      "integrity": "sha512-t7dhREVv6dbNj0q17X12j7yDG4bD/DHYX7o5/DbDxobP0HnGPgpRz2Ej77aL7TZT3DSw13fqUTj8J4mMnqa7WA==",
      "dev": true
    },
    "node_modules/@types/mime": {
@@ -9026,12 +9026,12 @@
      }
    },
    "node_modules/playwright": {
-      "version": "1.39.0",
-      "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.39.0.tgz",
-      "integrity": "sha512-naE5QT11uC/Oiq0BwZ50gDmy8c8WLPRTEWuSSFVG2egBka/1qMoSqYQcROMT9zLwJ86oPofcTH2jBY/5wWOgIw==",
+      "version": "1.42.1",
+      "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.42.1.tgz",
+      "integrity": "sha512-PgwB03s2DZBcNRoW+1w9E+VkLBxweib6KTXM0M3tkiT4jVxKSi6PmVJ591J+0u10LUrgxB7dLRbiJqO5s2QPMg==",
      "dev": true,
      "dependencies": {
-        "playwright-core": "1.39.0"
+        "playwright-core": "1.42.1"
      },
      "bin": {
        "playwright": "cli.js"
@@ -9048,7 +9048,6 @@
      "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.42.1.tgz",
      "integrity": "sha512-mxz6zclokgrke9p1vtdy/COWBH+eOZgYUVVU34C73M+4j4HLlQJHtfcqiqqxpP0o8HhMkflvfbquLX5dg6wlfA==",
      "dev": true,
-      "peer": true,
      "bin": {
        "playwright-core": "cli.js"
      },
@@ -9070,18 +9069,6 @@
        "node": "^8.16.0 || ^10.6.0 || >=11.0.0"
      }
    },
-    "node_modules/playwright/node_modules/playwright-core": {
-      "version": "1.39.0",
-      "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.39.0.tgz",
-      "integrity": "sha512-+k4pdZgs1qiM+OUkSjx96YiKsXsmb59evFoqv8SKO067qBA+Z2s/dCzJij/ZhdQcs2zlTAgRKfeiiLm8PQ2qvw==",
-      "dev": true,
-      "bin": {
-        "playwright-core": "cli.js"
-      },
-      "engines": {
-        "node": ">=16"
-      }
-    },
    "node_modules/plotly.js-basic-dist-min": {
      "version": "2.29.1",
      "resolved": "https://registry.npmjs.org/plotly.js-basic-dist-min/-/plotly.js-basic-dist-min-2.29.1.tgz",
--- a/package.json
+++ b/package.json
@@ -10,14 +10,14 @@
    "@braintree/sanitize-url": "6.0.4",
    "@percy/cli": "1.27.4",
    "@percy/playwright": "1.0.4",
-    "@playwright/test": "1.39.0",
+    "@playwright/test": "1.42.1",
    "@types/d3-axis": "3.0.6",
    "@types/d3-shape": "3.0.0",
    "@types/d3-scale": "4.0.8",
    "@types/d3-selection": "3.0.10",
    "@types/eventemitter3": "1.2.0",
    "@types/jasmine": "5.1.2",
-    "@types/lodash": "4.14.192",
+    "@types/lodash": "4.17.0",
    "@vue/compiler-sfc": "3.4.3",
    "babel-loader": "9.1.0",
    "babel-plugin-istanbul": "6.1.1",
@@ -156,4 +156,4 @@
  "keywords": [
    "nasa"
  ]
-}
+}
--- a/src/plugins/condition/ConditionManager.js
+++ b/src/plugins/condition/ConditionManager.js
@@ -364,7 +364,7 @@ export default class ConditionManager extends EventEmitter {
    let nextLegOptions = { ...options };
    delete nextLegOptions.onPartialResponse;

-    const results = Promise.all(
+    const results = await Promise.all(
      this.conditions.map((condition) => condition.requestLADConditionResult(nextLegOptions))
    );
Author	SHA1	Message	Date
David Tsay	cc58dbd5e7	Merge branch 'master' into eval-source-maps	2024-03-25 11:12:17 -07:00
Jesse Mazzella	d68ac31ab5	chore: bump `@playwright/test` to `1.42.1` (#7627 ) * chore: bump `@playwright/test` to `1.42.1` * chore(circleci): don't try to re-run individual percy tests	2024-03-21 09:27:41 -07:00
Jesse Mazzella	f504ee29cc	fix: 🤖 beep boop beep, you forgot an `await` 🤖 (#7630 ) * fix: 🤖 beep boop beep, you forgot an `await` 🤖 * add e2e test --------- Co-authored-by: Scott Bell <scott@traclabs.com>	2024-03-20 20:20:48 +00:00
dependabot[bot]	1d5ddc545e	chore(deps-dev): bump @types/lodash from 4.14.192 to 4.17.0 (#7610 ) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.192 to 4.17.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-03-19 22:57:38 -07:00
John Hill	42085a4b70	[CI] Parallelize visual test runs (#7618 ) * rename suite and add parallelism * use test sharding * expect 2 parallel runs --------- Co-authored-by: Scott Bell <scott@traclabs.com>	2024-03-19 20:50:14 -07:00
David Tsay	c19c4e7065	Merge branch 'master' into eval-source-maps	2024-03-15 10:41:14 -07:00
David Tsay	3bb4df8d39	enable eval-source-maps	2024-03-13 12:34:29 -07:00