Refactor conditions

- Disallow pause and play in time strip view for plots.

index.html

@@ -194,7 +194,6 @@
             ['table', 'telemetry.plot.overlay', 'telemetry.plot.stacked'],
             {indicator: true}
         ));
-        //openmct.install(openmct.plugins.CodeWalkthrough);
         openmct.start();
     </script>
 </html>

src/plugins/LADTable/plugin.js

@@ -30,7 +30,7 @@ export default function plugin() {
         openmct.objectViews.addProvider(new LADTableSetViewProvider(openmct));
 
         openmct.types.addType('LadTable', {
-            name: "Latest Data Table",
+            name: "LAD Table",
             creatable: true,
             description: "A Latest Available Data tabular view in which each row displays the values for one or more contained telemetry objects.",
             cssClass: 'icon-tabular-lad',

src/plugins/codeWalkthrough/plugin.js

@@ -1,63 +0,0 @@
-export default function install(openmct) {
-    openmct.objectViews.addProvider({
-        name: "Data Table",
-        key: "data-table",
-        cssClass: "icon-packet",
-        description: "Tabular view of telemetry",
-        canView(domainObject) {
-            return true;
-        },
-        view(domainObject) {
-            return {
-                async show(element) {
-                    let telemetryMetadata = openmct.telemetry.getMetadata(domainObject).values();
-                    let table = document.createElement('table');
-                    let tableHead = document.createElement('thead');
-                    let tableBody = document.createElement('tbody');
-                    let tableHeadRow = document.createElement('tr');
-
-                    tableHead.appendChild(tableHeadRow);
-                    table.appendChild(tableHead);
-                    table.appendChild(tableBody);
-                    element.appendChild(table);
-
-                    telemetryMetadata.forEach(metadatum => {
-                        let tableHeadCell = document.createElement('td');
-                        tableHeadRow.appendChild(tableHeadCell);
-
-                        tableHeadCell.innerText = metadatum.name;
-                    });
-
-                    async function requestTelemetry() {
-                        let telemetry = await openmct.telemetry.request(domainObject);
-                        telemetry.forEach((datum) => {
-                            let dataRow = document.createElement('tr');
-                            telemetryMetadata.forEach(metadatum => {
-                                let dataCell = document.createElement('td');
-                                let formatter = openmct.telemetry.getValueFormatter(metadatum);
-
-                                let telemetryValue = formatter.format(datum[metadatum.key]);
-                                dataCell.innerText = telemetryValue;
-                                dataRow.appendChild(dataCell);
-                            });
-                            tableBody.appendChild(dataRow);
-                        });
-                    }
-
-                    openmct.time.on('bounds', () => {
-                        tableBody.innerHTML = '';
-                        requestTelemetry();
-                    });
-
-                    requestTelemetry();
-
-                    // openmct.telemetry.subscribe(domainObject, (datum) => {
-                    //     element.innerText = JSON.stringify(datum);
-                    // });
-                },
-                destroy() {
-                }
-            };
-        }
-    });
-}

src/plugins/condition/ConditionManager.js

@@ -41,7 +41,7 @@ export default class ConditionManager extends EventEmitter {
         this.subscriptions = {};
         this.telemetryObjects = {};
         this.testData = {
-            conditionTestData: [],
+            conditionTestInputs: this.conditionSetDomainObject.configuration.conditionTestData,
             applied: false
         };
         this.initialize();
@@ -154,8 +154,10 @@ export default class ConditionManager extends EventEmitter {
 
     updateConditionDescription(condition) {
         const found = this.conditionSetDomainObject.configuration.conditionCollection.find(conditionConfiguration => (conditionConfiguration.id === condition.id));
-        found.summary = condition.description;
-        this.persistConditions();
+        if (found.summary !== condition.description) {
+            found.summary = condition.description;
+            this.persistConditions();
+        }
     }
 
     initCondition(conditionConfiguration, index) {
@@ -414,8 +416,10 @@ export default class ConditionManager extends EventEmitter {
     }
 
     updateTestData(testData) {
-        this.testData = testData;
-        this.openmct.objects.mutate(this.conditionSetDomainObject, 'configuration.conditionTestData', this.testData.conditionTestInputs);
+        if (!_.isEqual(testData, this.testData)) {
+            this.testData = testData;
+            this.openmct.objects.mutate(this.conditionSetDomainObject, 'configuration.conditionTestData', this.testData.conditionTestInputs);
+        }
     }
 
     persistConditions() {

src/plugins/plot/MctPlot.vue

@@ -427,9 +427,12 @@ export default {
                 this.skipReloadOnInteraction = false;
                 this.loadMoreData(newRange, true);
             } else {
+                // If we're not panning or zooming (time conductor and plot x-axis times are not out of sync)
                 // Drop any data that is more than 1x (max-min) before min.
                 // Limit these purges to once a second.
-                if (!this.nextPurge || this.nextPurge < Date.now()) {
+                const isPanningOrZooming = this.isTimeOutOfSync;
+                const purgeRecords = !isPanningOrZooming && (!this.nextPurge || (this.nextPurge < Date.now()));
+                if (purgeRecords) {
                     const keepRange = {
                         min: newRange.min - (newRange.max - newRange.min),
                         max: newRange.max

src/plugins/plugins.js

@@ -65,8 +65,7 @@ define([
     './interceptors/plugin',
     './performanceIndicator/plugin',
     './CouchDBSearchFolder/plugin',
-    './timeline/plugin',
-    './codeWalkthrough/plugin'
+    './timeline/plugin'
 ], function (
     _,
     UTCTimeSystem,
@@ -112,8 +111,7 @@ define([
     ObjectInterceptors,
     PerformanceIndicator,
     CouchDBSearchFolder,
-    Timeline,
-    CodeWalkthrough
+    Timeline
 ) {
     const bundleMap = {
         LocalStorage: 'platform/persistence/local',
@@ -214,7 +212,6 @@ define([
     plugins.PerformanceIndicator = PerformanceIndicator.default;
     plugins.CouchDBSearchFolder = CouchDBSearchFolder.default;
     plugins.Timeline = Timeline.default;
-    plugins.CodeWalkthrough = CodeWalkthrough.default;
 
     return plugins;
 });

src/ui/preview/preview-header.vue

@@ -103,10 +103,16 @@ export default {
     },
     mounted() {
         if (this.actionCollection) {
+            this.actionCollection.hide(HIDDEN_ACTIONS);
             this.actionCollection.on('update', this.updateActionItems);
             this.updateActionItems(this.actionCollection.getActionsObject());
         }
     },
+    destroyed() {
+        if (this.actionCollection) {
+            this.actionCollection.off('update', this.updateActionItems);
+        }
+    },
     methods: {
         setView(view) {
             this.$emit('setView', view);
@@ -116,7 +122,6 @@ export default {
             delete this.actionCollection;
         },
         updateActionItems() {
-            this.actionCollection.hide(HIDDEN_ACTIONS);
             this.statusBarItems = this.actionCollection.getStatusBarActions();
             this.menuActionItems = this.actionCollection.getVisibleActions();
         },