alihan/rqlite-distributed-sql
1
0
Fork 0
mirror of https://github.com/rqlite/rqlite.git synced 2022-10-30 02:37:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Clean up unncessary conditional. Add explicit auth/ tests for empty credentials/anonymous case

Browse Source
This commit is contained in:
Neal Harrington
2022-07-25 22:02:28 -04:00
parent 7cceb822a4
commit 8921ee002e
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
auth/credential_store_test.go
View File

@@ -227,10 +227,19 @@ func Test_AuthPermsAA(t *testing.T) {
if store.AA("nonexistent", "password1", "foo") {
t.Fatalf("nonexistent authenticated and authorized for foo")
}
if !store.AA("nonexistent", "password1", "qux") {
t.Fatalf("nonexistent not authenticated and authorized for qux")
}
// explicit check of anonymous user
if !store.AA("", "", "qux") {
t.Fatalf("anonymous incorrectly not authorized")
}
if store.AA("", "", "foo") {
t.Fatalf("anonymous incorrectly authorized")
}
if !store.AA("username1", "password1", "foo") {
t.Fatalf("username1 not authenticated and authorized for foo")
}

9
cluster/service.go
View File

@@ -182,12 +182,9 @@ func (s *Service) checkCommandPerm(c *Command, perm string) bool {
return true
}
var username string
var password string
if c.Credentials == nil {
username = ""
password = ""
} else {
username := ""
password := ""
if c.Credentials != nil {
username = c.Credentials.GetUsername()
password = c.Credentials.GetPassword()
}