alihan/selenium-4-grid-k8s-docker
1
0
Fork 0
mirror of https://github.com/burakkaygusuz/selenium-4-grid-k8s-docker.git synced 2021-06-27 00:03:24 +03:00
Code Issues Projects Releases Wiki Activity

Remove the argument from the abstract method

Browse Source
This commit is contained in:
Burak Kaygusuz
2021-04-11 12:54:07 +03:00
parent 4b42999571
commit c605528d37
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/java/com/burakkaygusuz/config/DriverFactory.java
View File

@@ -24,13 +24,13 @@ public class DriverFactory {
try {
switch (browser) {
case CHROME:
driver = CHROME.getDriver(HUB_URL);
driver = CHROME.getDriver();
break;
case FIREFOX:
driver = FIREFOX.getDriver(HUB_URL);
driver = FIREFOX.getDriver();
break;
case EDGE:
driver = EDGE.getDriver(HUB_URL);
driver = EDGE.getDriver();
default:
throw new IllegalStateException(String.format("An unexpected driver has been attempted to init: \n %s", browser));
}

16
src/test/java/com/burakkaygusuz/config/DriverType.java
View File

@@ -18,12 +18,14 @@ import java.util.Map;
import java.util.logging.Level;
import java.util.logging.Logger;
import static com.burakkaygusuz.config.DriverFactory.*;
public enum DriverType {
CHROME {
@Override
public RemoteWebDriver getDriver(String url) throws MalformedURLException {
return new RemoteWebDriver(new URL(url), CHROME.getOptions());
public RemoteWebDriver getDriver() throws MalformedURLException {
return new RemoteWebDriver(new URL(HUB_URL), CHROME.getOptions());
}
@Override
@@ -52,8 +54,8 @@ public enum DriverType {
FIREFOX {
@Override
public RemoteWebDriver getDriver(String url) throws MalformedURLException {
return new RemoteWebDriver(new URL(url), FIREFOX.getOptions());
public RemoteWebDriver getDriver() throws MalformedURLException {
return new RemoteWebDriver(new URL(HUB_URL), FIREFOX.getOptions());
}
@Override
@@ -78,8 +80,8 @@ public enum DriverType {
EDGE {
@Override
public RemoteWebDriver getDriver(String url) throws MalformedURLException {
return new RemoteWebDriver(new URL(url), EDGE.getOptions());
public RemoteWebDriver getDriver() throws MalformedURLException {
return new RemoteWebDriver(new URL(HUB_URL), EDGE.getOptions());
}
@Override
@@ -99,7 +101,7 @@ public enum DriverType {
}
};
protected abstract RemoteWebDriver getDriver(String url) throws MalformedURLException;
protected abstract RemoteWebDriver getDriver() throws MalformedURLException;
protected abstract AbstractDriverOptions<?> getOptions();
}