alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Change all containers so they don't inherit bindings

Browse Source 
This is, to some degree, rendered moot by #2332, but for the moment it still
feels worth doing. The initial intention was to make sure that non-scrolling
containers and their child classes don't have bindings that may mask other
uses for navigation keys. However, it was realised that the "problem"
affected more than just containers (hence #2332).

But... on the off chance we add any more default bindings to
`Widget` (unlikely, but still), this will mean that they don't leak into the
containers unless we intend them to.

See #2331.
This commit is contained in:
Dave Pearson
2023-04-20 09:49:06 +01:00
parent 7d82e30684
commit 8a909b0d0a
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/textual/containers.py
View File

@@ -23,7 +23,7 @@ class Container(Widget):
"""
class ScrollableContainer(Widget):
class ScrollableContainer(Widget, inherit_bindings=False):
"""Base container widget that binds navigation keys for scrolling."""
BINDINGS: ClassVar[list[BindingType]] = [
@@ -51,7 +51,7 @@ class ScrollableContainer(Widget):
"""
class Vertical(Widget):
class Vertical(Widget, inherit_bindings=False):
"""A container which arranges children vertically."""
DEFAULT_CSS = """
@@ -75,7 +75,7 @@ class VerticalScroll(ScrollableContainer, can_focus=True):
"""
class Horizontal(Widget):
class Horizontal(Widget, inherit_bindings=False):
"""A container which arranges children horizontally."""
DEFAULT_CSS = """
@@ -99,7 +99,7 @@ class HorizontalScroll(ScrollableContainer, can_focus=True):
"""
class Center(Widget):
class Center(Widget, inherit_bindings=False):
"""A container which centers children horizontally."""
DEFAULT_CSS = """
@@ -111,7 +111,7 @@ class Center(Widget):
"""
class Middle(Widget):
class Middle(Widget, inherit_bindings=False):
"""A container which aligns children vertically in the middle."""
DEFAULT_CSS = """
@@ -123,7 +123,7 @@ class Middle(Widget):
"""
class Grid(Widget):
class Grid(Widget, inherit_bindings=False):
"""A container with grid alignment."""
DEFAULT_CSS = """
@@ -134,7 +134,7 @@ class Grid(Widget):
"""
class Content(Widget, can_focus=True, can_focus_children=False):
class Content(Widget, can_focus=True, can_focus_children=False, inherit_bindings=False):
"""A container for content such as text."""
DEFAULT_CSS = """