Commit Graph

4245 Commits

Author SHA1 Message Date
Dave Pearson
05b3ab6c78 Refine the explanation of percentage
Co-authored-by: Will McGugan <willmcgugan@gmail.com>
2023-01-18 10:05:40 +00:00
Dave Pearson
330950e6b0 Seek to improve the explanation of what a percentage does
I've seen a couple or so folk get confused about what a percentage value for
a dimension means, often seeming to think it means that percentage of
the *remaining* space within a container as opposed to a percentage of the
space in the container (note total space, not remaining space).

I'm not sure the wording here is the final form we want (there's more
mention of "dimension" here than your average Star Trek or Doctor Who
episode!), but I think it's narrowing in on it.

Making this change to place-hold the need to improve this and perhaps gather
some input to find the best final wording.
2023-01-17 16:33:30 +00:00
Will McGugan
fc2073386c Merge pull request #1591 from davep/compose-error-expand
Reraise compose TypeError from the error rather than None
2023-01-17 07:45:30 -08:00
Will McGugan
507413d473 updated text 2023-01-17 15:39:59 +00:00
Will McGugan
3104ae0d9d Merge branch 'key-minus' 2023-01-17 15:38:40 +00:00
Will McGugan
f13b7f7fe5 Merge pull request #1596 from Textualize/key-minus
Key minus
2023-01-17 07:36:12 -08:00
Will McGugan
1bfc19f480 help message 2023-01-17 15:24:31 +00:00
Will McGugan
e32344615a Added test 2023-01-17 15:19:40 +00:00
Will McGugan
2bd1372c38 added minus key 2023-01-17 15:18:31 +00:00
Dave Pearson
984fa41de5 Fix typo/thinko in CHANGELOG 2023-01-17 14:25:44 +00:00
Will McGugan
c2a6e2f8b5 Merge pull request #1581 from Textualize/fix-textlog-wrap
Fixes for textlog issues
2023-01-17 06:23:11 -08:00
Dave Pearson
16f21ecfc8 Reraise compose TypeError from the error rather than None
In its current form, if someone's `compose` results in an uncaught TypeError
in their own code, the resulting error will hide the source. This small
change ensures that the main problem (compose returned something that can't
be turned into a list) is still reported, but also provides the developer a
trackback they can look at to see what the ultimate source of the issue was.
2023-01-17 14:22:32 +00:00
Will McGugan
2956f1f4d8 update change log [skip ci] 2023-01-17 14:22:25 +00:00
Rodrigo Girão Serrão
4078634d57 Merge pull request #1586 from Textualize/rodrigogiraoserrao-patch-1
Docstring correction
2023-01-17 11:01:18 +00:00
Rodrigo Girão Serrão
518c721ecf Docstring correction 2023-01-17 10:44:49 +00:00
Will McGugan
e6d89dd839 docstring 2023-01-17 10:10:16 +00:00
Will McGugan
a521640dac Fixes for textlog issues 2023-01-17 09:55:56 +00:00
Dave Pearson
cc5338ea5a Merge pull request #1578 from davep/prop-chop-doc
Add some extra docstrings to widgets
2023-01-16 16:34:26 +00:00
Will McGugan
fb1bd6ad48 Merge pull request #1550 from davep/issue/1201/scroll-to-with-code
Allow by-code scrolling even when by-input scrolling would be denied
2023-01-16 07:47:58 -08:00
Dave Pearson
632e82818d Merge pull request #1570 from davep/title-docs
Add docstrings to app title an sub-titles
2023-01-16 15:45:13 +00:00
Dave Pearson
6c64773996 Merge branch 'main' into issue/1201/scroll-to-with-code 2023-01-16 15:42:39 +00:00
Dave Pearson
2b2d6c730c Correct over-eager remove of if constructs
That's how I'm reading 1b9f51a272 (r1070555064)
2023-01-16 15:41:20 +00:00
Dave Pearson
00291e7c99 Make some of Input's docstrings more property-like 2023-01-16 15:32:49 +00:00
Dave Pearson
d5ffc4e0ac Add a docstring to the __init__of Input 2023-01-16 15:32:28 +00:00
Dave Pearson
23bfb08693 Merge pull request #1574 from Galmo13/patch-1
Fixed a typo in Examples/README.md
2023-01-16 15:10:44 +00:00
Galmo13
affcb60d9b Fixed a typo
Fixed a "buy" by a "by".
2023-01-16 16:07:58 +01:00
Dave Pearson
3dae3ae5d2 Document the reactive properties of the Checkbox 2023-01-16 14:51:01 +00:00
Dave Pearson
2e84902207 Document some of the Button reactive properties 2023-01-16 14:47:34 +00:00
Dave Pearson
09487a36ed Remove typing from Binding property docstrings
See #1573.
2023-01-16 12:59:23 +00:00
Dave Pearson
cb7adb78bf Move the title and sub_title docstrings to __ini__
According to the current working of out documentation generation pipeline,
this is the way to document a reactive property that is referred to within
the owner class' __init__.

See #1572 and #1564.
2023-01-16 10:32:49 +00:00
Dave Pearson
f72a4cfa8c Document the sub_title reactive instance attribute
See #1564.
2023-01-16 07:06:33 +00:00
Dave Pearson
7f9c109a79 Document the title reactive instance attribute
See #1564.
2023-01-16 07:00:18 +00:00
Dave Pearson
97248d202b Document the SUB_TITLE class attribute
See #1564.
2023-01-16 06:56:47 +00:00
Dave Pearson
f9d0796d77 Document the TITLE class attribute
See #1564.
2023-01-16 06:54:07 +00:00
Will McGugan
45abae5888 Merge pull request #1546 from Textualize/fix-1399
Make `COMPONENT_CLASSES` inheritable and add classvar to prevent inheritance.
2023-01-15 02:43:48 -08:00
Will McGugan
974a0b8020 Merge branch 'main' into fix-1399 2023-01-15 02:43:41 -08:00
Dave Pearson
1b9f51a272 Merge branch 'main' into issue/1201/scroll-to-with-code 2023-01-15 10:36:21 +00:00
Dave Pearson
843810ef17 Remove no-scroll guard from scroll watchers 2023-01-15 10:35:20 +00:00
Dave Pearson
8b3608ec8b Merge branch 'issue/1201/scroll-to-with-code' of github.com:davep/textual into issue/1201/scroll-to-with-code 2023-01-15 10:33:07 +00:00
Will McGugan
2468a8ca83 Merge pull request #1555 from Textualize/rodrigogiraoserrao-patch-1
Fix tests: await all mounts before checking rendered values
2023-01-15 02:30:41 -08:00
Will McGugan
7dcfcadeeb Merge pull request #1561 from davep/tweak-query-one-docs
Tweak `query_one` and related methods docstrings
2023-01-15 02:30:29 -08:00
Will McGugan
831ef70610 Merge pull request #1558 from Textualize/reactive-work
Reactive refactor and fixes
2023-01-15 02:15:15 -08:00
Will McGugan
582aadb4b2 docstring [skip ci] 2023-01-15 10:10:52 +00:00
Will McGugan
6d57ba4623 docstring fix 2023-01-13 22:17:48 +00:00
Will McGugan
6063b0c9b2 remove comment [skip ci] 2023-01-13 21:17:19 +00:00
Will McGugan
6af2b61fc7 watching computed 2023-01-13 20:56:33 +00:00
Will McGugan
35cbd30fb7 fix superfluous scrollbars 2023-01-13 20:50:00 +00:00
Will McGugan
5f77cd189f fix reactive computes 2023-01-13 18:18:12 +00:00
Will McGugan
90f570494d docstring 2023-01-13 17:40:42 +00:00
Will McGugan
fb5dccf739 fix return 2023-01-13 17:37:02 +00:00