Commit Graph

4229 Commits

Author SHA1 Message Date
Darren Burns
65223be8be Merge branch 'main' of github.com:Textualize/textual into datatable-events 2023-01-16 11:00:10 +00:00
Darren Burns
2814e1f93c Documentation updates 2023-01-16 10:50:41 +00:00
Darren Burns
e3aebc4215 Switching to BINDINGS instead of key_* methods in DataTable 2023-01-16 10:27:45 +00:00
Darren Burns
62c05f7fbc Update datatable snapshot - hover cursor no longer shown 2023-01-16 10:01:02 +00:00
Will McGugan
45abae5888 Merge pull request #1546 from Textualize/fix-1399
Make `COMPONENT_CLASSES` inheritable and add classvar to prevent inheritance.
2023-01-15 02:43:48 -08:00
Will McGugan
974a0b8020 Merge branch 'main' into fix-1399 2023-01-15 02:43:41 -08:00
Will McGugan
2468a8ca83 Merge pull request #1555 from Textualize/rodrigogiraoserrao-patch-1
Fix tests: await all mounts before checking rendered values
2023-01-15 02:30:41 -08:00
Will McGugan
7dcfcadeeb Merge pull request #1561 from davep/tweak-query-one-docs
Tweak `query_one` and related methods docstrings
2023-01-15 02:30:29 -08:00
Will McGugan
831ef70610 Merge pull request #1558 from Textualize/reactive-work
Reactive refactor and fixes
2023-01-15 02:15:15 -08:00
Will McGugan
582aadb4b2 docstring [skip ci] 2023-01-15 10:10:52 +00:00
Will McGugan
6d57ba4623 docstring fix 2023-01-13 22:17:48 +00:00
Will McGugan
6063b0c9b2 remove comment [skip ci] 2023-01-13 21:17:19 +00:00
Will McGugan
6af2b61fc7 watching computed 2023-01-13 20:56:33 +00:00
Will McGugan
35cbd30fb7 fix superfluous scrollbars 2023-01-13 20:50:00 +00:00
Will McGugan
5f77cd189f fix reactive computes 2023-01-13 18:18:12 +00:00
Will McGugan
90f570494d docstring 2023-01-13 17:40:42 +00:00
Will McGugan
fb5dccf739 fix return 2023-01-13 17:37:02 +00:00
Will McGugan
40434e7ef1 co_compute to compute 2023-01-13 17:36:41 +00:00
Dave Pearson
9a396ece29 Expand the docstring for DOMNode.query_one
See #1560. In short: query_one was changed a couple of months back so that
it searched for only a single instance of a hit for the query, rather
than (as before) returning the first item that matched the query.
Unfortunately the docstring didn't get the necessary update.

This should hopefully make things a wee bit clearer in the docs.
2023-01-13 17:33:23 +00:00
Dave Pearson
f7c671f710 Update DOMQuery.only_one to include NoMatches in raises list
See #1560
2023-01-13 17:25:32 +00:00
Will McGugan
c3129c8331 fix inheritance 2023-01-13 17:22:52 +00:00
Rodrigo Girão Serrão
7e428e2f4c fix tests: await all mounts. 2023-01-13 10:58:57 +00:00
Will McGugan
8f0f0d8c12 refactor 2023-01-13 10:44:13 +00:00
Will McGugan
027635b978 merge 2023-01-12 17:45:36 +00:00
Darren Burns
ba997a8e2b Ensure cursor position always respects fixed columns 2023-01-12 17:13:05 +00:00
Rodrigo Girão Serrão
feb8591e72 Fix test: await widget mount before focusing
Follow-up to #1548
2023-01-12 16:11:36 +00:00
Rodrigo Girão Serrão
510df0c375 Merge branch 'main' into fix-1399 2023-01-12 15:50:06 +00:00
Rodrigo Girão Serrão
a3e54323d9 Make methods private. 2023-01-12 15:48:49 +00:00
Rodrigo Girão Serrão
ab0d9d569e Merge pull request #1548 from Textualize/fix-1477
Improve `Input` view position calculation
2023-01-12 15:13:03 +00:00
Rodrigo Girão Serrão
b9d9e148d8 Merge pull request #1553 from Textualize/rodrigogiraoserrao-patch-1
Make list_view snapshot test pass more reliably
2023-01-12 15:07:20 +00:00
Rodrigo Girão Serrão
dd478dd249 Make list_view snapshot test pass more reliably 2023-01-12 15:00:56 +00:00
Rodrigo Girão Serrão
dff226efa2 Update docstring. 2023-01-12 14:49:16 +00:00
Darren Burns
ce83ac6430 Simplify cursor scroll into view 2023-01-12 14:18:48 +00:00
Darren Burns
641fd542a4 Fix some issues with scrolling/cursor movement 2023-01-12 14:16:55 +00:00
Darren Burns
f66a276824 Small refactor datatable 2023-01-12 13:41:33 +00:00
Rodrigo Girão Serrão
0762a6b858 Merge pull request #1552 from Textualize/fix-1459
Match clock color to header color.
2023-01-12 12:13:58 +00:00
Rodrigo Girão Serrão
922c2273b1 Match clock color to header. 2023-01-12 12:03:16 +00:00
Dave Pearson
b6bf7595b8 Merge pull request #1549 from davep/cli-diagnose-tweak
Textual diagnose command code tweaks
2023-01-12 10:38:15 +00:00
Darren Burns
b0c72abe78 Ensure scroll_to_region always accounts for fixed rows/columns 2023-01-12 10:30:29 +00:00
Rodrigo Girão Serrão
461af6b7c3 Merge pull request #1544 from Textualize/fix-placeholder-docs
Fix doc issue.
2023-01-12 10:24:57 +00:00
Dave Pearson
2c4a889d71 Tidy up the output of the console dimensions 2023-01-12 09:33:46 +00:00
Dave Pearson
dad930d390 Add a missing return value to a docstring 2023-01-12 09:27:14 +00:00
Rodrigo Girão Serrão
6a495005b6 Changelog. 2023-01-11 19:21:31 +00:00
Rodrigo Girão Serrão
0bc10f0ec4 Add regression tests. 2023-01-11 19:15:10 +00:00
Rodrigo Girão Serrão
5035c29b87 Add early return in view_position calculation.
When an input is instantiated without an argument for the parameter 'value', the first time the watchers associated with its reactive attributes run, the attribute self.view_position is set to 1, which makes no sense because there isn't even any value in the input. Thus, when the value is later modified programmatically, e.g., because it is set with 'some_input_widget.value = some_value', the attribute self.view_position will still be 1 and the text will be rendered starting from the first character.
As two example situations of this, consider #1477 and #1443.
2023-01-11 18:52:00 +00:00
Darren Burns
731f152147 Hide the hover cursor when the keyboard is used 2023-01-11 17:21:01 +00:00
Darren Burns
d3915e166a Add internal state for showing/hiding hover cursor 2023-01-11 17:06:31 +00:00
Darren Burns
9753bb940e Only permitting valid movements based on cursor type 2023-01-11 16:58:34 +00:00
Darren Burns
fa931aec5e Improving some datatable variable names 2023-01-11 16:24:52 +00:00
Rodrigo Girão Serrão
d966665345 Address review comments. 2023-01-11 16:05:44 +00:00