alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity
6,419 Commits 87 Branches 190 Tags
65b0c34f2ed6a69795946a0735a51a463602545c
Commit Graph

6419 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dave Pearson
65b0c34f2e Merge pull request #2660 from davep/dirtree-tweaks 2023-05-26 15:18:58 +01:00
Dave Pearson
ec3334e633 Perform the "is loaded" test in _add_to_load_queue 
The test if a node was loaded wasn't being performed when loading the root.
This ensures that will happen. I suspect this is (no pun...) at the root of
the issue with https://github.com/Textualize/frogmouth/issues/50 even though
I can't see the route into how this happens, and can't recreate this at
will.

This feels like a worthwhile change to make anyway as it's a safer approach.
 2023-05-25 20:55:22 +01:00
Dave Pearson
32790de26a Ensure a node has no children before populating it 
I'm struggling to recreate https://github.com/Textualize/frogmouth/issues/50
in a controlled way, but reviewing the code here makes me think that this is
a good idea anyway. While DirectoryTree should not end up in _populate_node
if a node has already been populated, it's also the case that it's an
all-or-nothing thing; it makes sense to clear out the children of the node
before populating it; at least in a belt-and-braces way.
 2023-05-25 20:49:50 +01:00
Dave Pearson
ea8c6039a9 Merge pull request #2652 from davep/multiselect 2023-05-25 17:10:20 +01:00
Dave Pearson
c16b32b52f Merge pull request #2656 from davep/private-validate-and-compute 
Add (currently xfailing) tests for private reactive validation and compute methods
 2023-05-25 15:53:24 +01:00
Dave Pearson
fa47d0bd41 Mark the public/private validate and compute tests as xfails 2023-05-25 15:27:27 +01:00
Dave Pearson
bd6717f3d5 Add a test for public and private computes 
This fails for now.
 2023-05-25 15:23:33 +01:00
Dave Pearson
400043dda1 Update snapshit tests 2023-05-25 14:47:11 +01:00
Dave Pearson
93cae8d961 Merge branch 'multiselect' of github.com:davep/textual into multiselect 2023-05-25 14:20:13 +01:00
Dave Pearson
658c1cdf73 Documentation punctuation change 2023-05-25 14:19:47 +01:00
Dave Pearson
4764c100e3 Fix a copy/pasteo 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 14:16:15 +01:00
Dave Pearson
aca8ec4833 Merge branch 'multiselect' of github.com:davep/textual into multiselect 2023-05-25 14:12:10 +01:00
Dave Pearson
45e64254e6 Be clear that _apply_to_all sends a SelectedChange message 2023-05-25 14:11:35 +01:00
Dave Pearson
95389ebe76 Fix a typo 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 14:05:05 +01:00
Dave Pearson
c69e53f77e Save a word! 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 14:04:32 +01:00
Dave Pearson
93c3c3652b Merge branch 'main' into multiselect 2023-05-25 13:59:34 +01:00
Dave Pearson
a944554d0d Finish a half-finished docstring 2023-05-25 13:58:31 +01:00
Dave Pearson
baa060f9fa Remove annotation from RHS of the typing example 2023-05-25 13:57:08 +01:00
Aaron Stephens
20d19d977d Refactor Message.control and Tree Messages (#2602) 
* refactor(message): make control a property

* refactor(_tree): remove tree parameter on messages

* refactor(_directory_tree): remove tree parameter on message

* fix: tree message calls

* fix(_select): make Changed.control a property

* refactor(_on): control check

* refactor(_select): rename Changed.widget to select

* docs: changelog entry
 2023-05-25 13:48:31 +01:00
Will McGugan
3ab315beb6 Anim screenshot fix (#2655) 
* fix screenshots in docs

* fix anim

* added wait for animation switch

* remove comment
 2023-05-25 13:46:14 +01:00
Dave Pearson
4c93e63ed6 Fix a copy/pasteo 2023-05-25 13:35:27 +01:00
darrenburns
62fcefbd2d Validation (#2600) 
* A few different types of validation

* Rename

* Fix test

* Updating validation framework

* Update lockfile

* Ensure validators can be None

* Reworking the API a little

* Convert Input.Changed to dataclass

* Add utility for getting failures as strings

* Update an example in Validator docstring

* Remove some redundant `pass`es

* Renaming variables

* Validating Input on submit, attaching result to Submitted event

* Testing various validation features

* Update snapshots and deps

* Styling unfocused -invalid Input differently

* Add snapshot test around input validation and associated styles

* Validation docs

* Tidying validation docs in Input widget reference

* Fix mypy issues

* Remove __bool__ from Failure, make validator field required

* Code review changes

* Improving error messages in Validators
 2023-05-25 13:29:33 +01:00
Dave Pearson
6d82d7a1db Fix a typo 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 13:27:31 +01:00
Dave Pearson
ad4c68ba0d Fix a typo 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 13:26:57 +01:00
Dave Pearson
d656fa6a79 Fix a typo 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 13:24:01 +01:00
Dave Pearson
51f8d0dc9a Break up the SelectionList snapshit tests 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 13:20:22 +01:00
Dave Pearson
51133b3a62 Typo fix 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 13:19:18 +01:00
Dave Pearson
34f7136f21 Fix a typo 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 13:14:27 +01:00
Dave Pearson
bec362e527 Improve the title for the widget 
It's sort moved on from been about check boxen.

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-25 13:04:12 +01:00
Rodrigo Girão Serrão
5cb30b5ecc Merge pull request #2628 from Textualize/auto-focus-improv 
Add auto focus to app.
 2023-05-25 11:59:54 +01:00
Rodrigo Girão Serrão
afbf52d8f5 Merge pull request #2654 from Textualize/progressbar-docs 
Fix progress bar docs issue.
 2023-05-25 11:59:37 +01:00
Dave Pearson
abda34aa13 Add a test for private validation 
Currently failing.
 2023-05-25 11:48:04 +01:00
Dave Pearson
4472c862be Anticipate SelectionList making it into 0.27.0 2023-05-25 11:28:52 +01:00
Dave Pearson
3796a849c4 Simplify _make_selection a wee bit 2023-05-25 11:21:50 +01:00
Dave Pearson
939586f5f8 Add snapshot tests for the SelectionList examples 2023-05-25 11:06:21 +01:00
Rodrigo Girão Serrão
08eb1f1fab Remove invalid ref. 2023-05-25 11:01:47 +01:00
Dave Pearson
9a0e82f4c3 Merge branch 'main' into multiselect 2023-05-25 10:04:52 +01:00
Dave Pearson
112f18b94d Add SelectionList to the widget gallery 2023-05-25 09:58:43 +01:00
Dave Pearson
4ceeefba23 Remove the attempt to link to Pretty 
Weirdly Pretty isn't in the docs. Yet.
 2023-05-25 09:42:12 +01:00
Dave Pearson
02c4f4d69b Add an example of using SelectionList.SelectedChanged 2023-05-25 09:35:37 +01:00
Dave Pearson
fe26b89803 Add some more hints about type hinting 
Also add a couple more useful links in the area I'm editing.
 2023-05-25 09:12:57 +01:00
Dave Pearson
2d544ca697 Rename the tuples selection list example to mention tuples 
Making this one look like it was *the* canonical example wasn't a good idea.
 2023-05-25 08:58:45 +01:00
Dave Pearson
a9100988b4 Make a start on the SelectionList example apps 2023-05-24 21:36:14 +01:00
Will McGugan
8151946f38 add blur (#2645) 
* add blur

* docstring

* blur on disabled

* snapshot test

* Add test
 2023-05-24 20:16:11 +01:00
Dave Pearson
a89c199409 Merge pull request #2646 from davep/fix-broken-xrefs 
Fix some assorted documentation cross-references
 2023-05-24 16:37:01 +01:00
Dave Pearson
bad2a5a064 Merge pull request #2647 from davep/fix-set-classes-docstring 
Fix docstring for `DOMNode.set_classes`
 2023-05-24 16:24:20 +01:00
Dave Pearson
2c184caa2a Fix docstring for DOMNode.set_classes 
The argument in the Args list was missing its name; also fixes a typo too.
 2023-05-24 16:16:15 +01:00
Dave Pearson
718760dcb1 Fix some assorted documentation cross-references 
Couple or so things I noticed while working on docs.
 2023-05-24 15:53:56 +01:00
Dave Pearson
3e4291cf94 Remove unnecessary inclusion of Selection 
It will be included by the nature of selection_list being included.
 2023-05-24 15:31:27 +01:00
Dave Pearson
e7876ca001 Merge branch 'main' into multiselect 2023-05-24 15:29:37 +01:00