Commit Graph

3855 Commits

Author SHA1 Message Date
Dave Pearson
b8500de1e9 Run black over recent immutable sequence view tests
Now that we're running black on tests...
2023-01-07 09:32:43 +00:00
Will McGugan
c7cb525a6a Merge pull request #1507 from Textualize/black-on-tests
run black on tests
2023-01-06 10:52:55 -08:00
darrenburns
a133bd84de Ensure pretty traceback for error in Widget compose method (#1505)
* Ensure pretty traceback for error in Widget compose method

* Fail fast and pretty tracebacks for Widget compose errors
2023-01-06 16:28:34 +00:00
Will McGugan
597a8923e9 run black on tests 2023-01-06 15:32:04 +00:00
Dave Pearson
82dcf62122 Merge pull request #1495 from davep/tree-node-children-prop
Add read-only access to the children of a `TreeNode`
2023-01-06 15:17:39 +00:00
Will McGugan
c0fa19fa16 Merge pull request #1504 from Textualize/fix-mouse01-example
Fix mouse01 example background transparency
2023-01-06 06:55:00 -08:00
Darren Burns
387a045cff Fix mouse01 example background transparency 2023-01-06 14:32:23 +00:00
Dave Pearson
0217462398 Add support for star/stop values on index
See https://github.com/Textualize/textual/pull/1495#pullrequestreview-1238616797
2023-01-06 12:31:59 +00:00
Dave Pearson
395ed4b153 Correct docstring for the return type of index 2023-01-06 12:31:27 +00:00
Dave Pearson
71cc1bca1e Rename ImmutableSequence to ImmutableSequenceView
Also, in doing so, drop support for unrolling iterators and making them into
indexable sequences.

See the following feedback:

  https://github.com/Textualize/textual/pull/1495#pullrequestreview-1238616797
  https://github.com/Textualize/textual/pull/1495#issuecomment-1373553580
2023-01-06 12:23:51 +00:00
Dave Pearson
82fe3e2a76 Merge pull request #1488 from davep/tree-node-parent-prop
Add a public read-only parent property to TreeNode
2023-01-06 12:17:55 +00:00
Will McGugan
428ae0e14e Merge branch 'main' into tree-node-parent-prop 2023-01-06 02:11:35 -08:00
Will McGugan
85afdba125 Merge pull request #1480 from Textualize/fix-1479
Prevent scrollbar rules from being ignored
2023-01-06 01:58:35 -08:00
Will McGugan
70bded01f3 Merge pull request #1456 from nitzan-shaked/typing
basic typing fixes
2023-01-06 01:57:04 -08:00
Will McGugan
8ea2eae77b Merge pull request #1500 from davep/faqtory-xkcd-327
Sanitise issue titles before running suggest on them
2023-01-06 01:53:58 -08:00
Dave Pearson
01e6ae43d0 Sanitise issue titles before running suggest on them
Applying
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
to #1472.
2023-01-06 06:43:41 +00:00
Dave Pearson
e5869b9f7b Merge branch 'main' into tree-node-children-prop 2023-01-06 06:18:15 +00:00
Dave Pearson
a15fa7fd01 Tweak the unit tests for ImmutableSequence
Make it 100% clear that the tests that are about wrapping iterators actually
are wrapping iterators.
2023-01-06 06:14:49 +00:00
Dave Pearson
83ce1204b9 Merge pull request #1487 from davep/tree-node-label-prop
Add public access (both get and set) to the `label` of a `TreeNode`
2023-01-06 06:13:34 +00:00
Dave Pearson
83c0ef73e3 Only convert to an indexable sequence if absolutely necessary 2023-01-06 06:01:59 +00:00
Dave Pearson
8d5ea89a65 Focus less on it being a list and more a thing that's wrapped 2023-01-05 23:16:51 +00:00
Dave Pearson
f9e00628ab Simplify ImmutableSequence.__bool__ 2023-01-05 23:06:42 +00:00
Dave Pearson
7779211dcf Add read-only access to the children of a TreeNode
See #1398.
2023-01-05 21:24:47 +00:00
Dave Pearson
30d5c1e66b Add a generic immutable sequence wrapper class
In anticipation of satisfying #1398, this adds a generic immutable sequence
wrapper class. The idea being that it can be used to wrap up a list or
similar, that you don't want the caller to modify.

This commit aims to get the basics down for this, and also adds a minimal
set of unit tests.
2023-01-05 21:11:14 +00:00
Will McGugan
ad70de5e87 added question 2023-01-05 21:06:30 +00:00
Rodrigo Girão Serrão
fb9e803863 Add default styles for scrollbar colors. 2023-01-05 16:22:51 +00:00
Dave Pearson
2c6bd88c53 Merge branch 'main' into tree-node-parent-prop 2023-01-05 14:31:51 +00:00
Dave Pearson
b8727a8908 Merge branch 'main' into tree-node-label-prop 2023-01-05 14:30:42 +00:00
Dave Pearson
18eae615cc Remove unnecessary return from label.setter
Python is expressive, but it ain't that expressive.
2023-01-05 14:26:45 +00:00
Nitzan Shaked
6e9d302e15 fix typing of tuple[] for py3.7 2023-01-05 14:23:40 +02:00
Will McGugan
6cfad7c4b3 Merge pull request #1466 from Textualize/sleep-tweak
don't sleep small intervals
2023-01-05 04:17:23 -08:00
Will McGugan
3be8f799c4 add constant 2023-01-05 12:07:42 +00:00
Nitzan Shaked
b78ca2bad2 more PR fixes 2023-01-05 14:02:15 +02:00
Nitzan Shaked
c1a90c25a1 black 2023-01-05 14:02:15 +02:00
Nitzan Shaked
5750666ad8 further PR fixes 2023-01-05 14:02:15 +02:00
Nitzan Shaked
080687ec60 fix PR comments thus far 2023-01-05 14:02:15 +02:00
Nitzan Shaked
05b10d8627 the very bare minimum typing fixes I need now. Sorry :/ 2023-01-05 14:02:15 +02:00
Will McGugan
89667b2231 Merge branch 'main' into sleep-tweak 2023-01-05 03:56:19 -08:00
Will McGugan
ffc9daf82a Merge branch 'main' into fix-1479 2023-01-05 03:47:27 -08:00
Will McGugan
0a35013696 Merge pull request #1458 from nitzan-shaked/mouse-events
MouseScrollUp/MouseScrollDown => plain MousEvent's
2023-01-05 03:41:09 -08:00
Will McGugan
9a4d61ac60 black 2023-01-05 11:34:07 +00:00
Will McGugan
5083cc188f Merge branch 'main' into mouse-events 2023-01-05 11:33:45 +00:00
Will McGugan
1465063b71 changelog 2023-01-05 11:33:16 +00:00
Will McGugan
d5c8516ee7 refactor for readability 2023-01-05 11:30:20 +00:00
Dave Pearson
27a7cfc489 Add a public read-only parent property to TreeNode
See #1397.
2023-01-05 10:35:25 +00:00
Dave Pearson
d39c59c414 Move the TreeNode label tests into a better-named file
There's going to be a whole bunch of tests relating to the Tree and TreeNode
coming, let's make sure this ends up being fairly granular.

(side thought: it might be a good time soon to revisit all the tests for
Textual and try and wrangle them into some tidy structure)
2023-01-05 10:01:52 +00:00
Dave Pearson
b8a329638e Add public access to a TreeNode's label
This adds public support to reading a TreeNode's label, and also setting it
too.

See #1396.
2023-01-05 09:37:08 +00:00
Dave Pearson
a1e63a1c02 Process the label on construction of a TreeNode
Currently there's an asymmetry in how the label is handled for a TreeNode.
If a str label is passed to the constructor it stays as a str type. On the
other hand, if it's set via set_label, it gets processed into a Rich Text
type. This commit removes that asymmetry.
2023-01-05 09:21:52 +00:00
Rodrigo Girão Serrão
f2108f0475 Make CI happy. 2023-01-04 15:01:12 +00:00
Rodrigo Girão Serrão
e717c3cfad Update changelog. 2023-01-04 14:51:43 +00:00