Commit Graph

5990 Commits

Author SHA1 Message Date
Dave Pearson
c45f9358ee Change RadioSet so it's less a container of widgets and more a widget
Initially we went with a RadioSet being a simple container of RadioButtons,
with the user navigating the RadioButtons like you would any other set of
widgets. This was fine but it became pretty clear pretty quickly that having
to tab through a non-trivial collection of buttons in a set to get to the
next widget wasn't ideal.

This commit, satisfying #2368, takes over the navigation of the buttons
within the container, makes the container itself a focusable widget, and
sets up some new bindings to allow a more natural and efficient interaction
with the set.
2023-04-25 15:00:44 +01:00
Dave Pearson
a6a373161f Add some unit testing of the new navigation 2023-04-25 12:06:46 +01:00
Dave Pearson
e16493bf81 Update the snapshot tests
This is necessary now that a focused RadioSet has acquired a border colour
similar to that if a focused Input.
2023-04-25 11:27:23 +01:00
Dave Pearson
59506f3292 Turn a RadioSet into a single focus switching site
With this commit a RadioSet becomes something you can tab into and out of
with just one keypress; navigation of the buttons within moves to being done
with the cursor keys instead.

See #2368.
2023-04-25 11:16:20 +01:00
Dave Pearson
b36afd80a7 Highlight a RadioSet when focus is within it 2023-04-25 10:13:30 +01:00
Dave Pearson
f1d70900cb Merge pull request #2367 from davep/tidy-builtin-actions
Tidy builtin actions
2023-04-24 16:13:35 +01:00
Dave Pearson
4047c83680 Update the CHANGELOG 2023-04-24 15:22:26 +01:00
Dave Pearson
b14b3b9e39 Expand the builtin action list in the docs 2023-04-24 15:12:51 +01:00
Dave Pearson
fee216132f Rename action_remove_class_ to action_remove_class 2023-04-24 15:02:22 +01:00
Dave Pearson
4d3cd1295f Rename action_add_class_ to action_add_class 2023-04-24 15:01:59 +01:00
Dave Pearson
d1ff1b33d6 Expand the docstring for action_back 2023-04-24 15:01:05 +01:00
Dave Pearson
7f4699605e Add a missing docstring argument for action_check_bindings 2023-04-24 14:59:12 +01:00
Dave Pearson
9371b47b9b Merge pull request #2365 from davep/no-container-scroll
Have `Container` *not* show scrollbars by default
2023-04-24 14:15:33 +01:00
Dave Pearson
2055a8996f Move the tutorial over to using ScrollableContainer 2023-04-24 13:13:11 +01:00
Dave Pearson
ca94c5eed0 Merge branch 'main' into no-container-scroll 2023-04-24 11:35:47 +01:00
Rodrigo Girão Serrão
e5033d7d23 Remove hanging lines from docstrings. (#2349)
* Remove hanging lines from docstrings.

Deleted hanging blank lines at the end of docstrings.

Regex pattern:
 - find `\n\n( *)"""`
 - replace with `\n$1"""`
2023-04-24 11:21:38 +01:00
Dave Pearson
a005b81a39 Update the CHANGELOG 2023-04-24 11:18:41 +01:00
Dave Pearson
b896e9d7f9 Update tests to handle scroll changes to Container
See #2361.
2023-04-24 11:10:37 +01:00
Dave Pearson
a91b2c6b35 By default hide the horizontal scrollbar on VerticalScroll
In connection with #2361.
2023-04-24 11:09:52 +01:00
Dave Pearson
d06a4e579d By default hide the vertical scrollbar on HorizontalScroll
In connection with #2361.
2023-04-24 11:09:09 +01:00
Dave Pearson
38e636921c Remove default scrollbars from Container
As per #2361 this removes default scrollbars on Container (and so adds them
on ScrollableContainer).
2023-04-24 11:06:31 +01:00
Will McGugan
80f4c12e76 Fix scroll flicker (#2358)
* fix scroll flicker

* fix scroll flicker

* remove event

* do not delay scroll

* remove comment

* test fix

* remove commented code

* comment

* increase pause on click

* changelog [skip ci]

* wait on resume

* remove note [skip ci]
2023-04-24 09:33:15 +01:00
Dave Pearson
8b6d9027e9 Merge pull request #2353 from davep/bug/2352/tabbed-content-active 2023-04-23 16:40:39 +01:00
Will McGugan
24a17ba914 Merge branch 'main' into bug/2352/tabbed-content-active 2023-04-23 16:04:06 +01:00
Rodrigo Girão Serrão
50030b427f Fix up/down key ansi sequences. (#2280)
* Fix up/down key ansi sequences.

Related issues: #2223.
Related comments: [my reply to OP](https://github.com/Textualize/textual/issues/2223\#issuecomment-1505512300) and [the OP's reply](https://github.com/Textualize/textual/issues/2223\#issuecomment-1506764562).

* Changelog.
2023-04-23 14:14:36 +01:00
Will McGugan
3736807359 fix color system render (#2360)
* fix color system render

* changelog
2023-04-22 17:49:00 +01:00
Dave Pearson
1a84be9fc9 Update the CHANGELOG 2023-04-22 10:29:00 +01:00
Dave Pearson
75543fbd4c Merge branch 'main' into bug/2352/tabbed-content-active 2023-04-22 10:28:02 +01:00
Will McGugan
a2633ca31e fix text opacity (#2356) 2023-04-22 08:50:14 +01:00
Dave Pearson
a351d620b2 Add some pauses to the UI-baed tabbed content tests
This particular test seems rather flakey in GitHub's actions. In most cases
passing, with the odd fail here and there (normally when unrelated changed
are made -- I've had this fail when docs have been changed; zero code
changes!)

So, on the off chance that a little extra pause will help...
2023-04-22 08:42:38 +01:00
Dave Pearson
c022d9de2f Fix TabbedContent.active not changing actual content
Ensures that the actual content gets changed when TabbedContent.active is
updated via code. Also adds more testing for TabbedContent.

See #2352 for details.
2023-04-22 08:28:12 +01:00
Dave Pearson
9e19706b53 Merge pull request #2345 from davep/button-docs-tweakage
Some more Button docs tidying
2023-04-21 09:07:25 +01:00
Dave Pearson
ccf4f06a74 Some more Button docs tidying
While I'm in this file... might as well link the word "variant" to the type
that it's referring to.
2023-04-21 07:57:48 +01:00
Dave Pearson
cd5d9d1e4f Merge pull request #2344 from davep/type-button-pressed-button-in-docs
Small improvement to the `Button.Pressed` event documentation
2023-04-21 07:47:51 +01:00
Dave Pearson
b34ab0d9a4 Small improvement to the Button.Pressed event documentation
This makes `button` as obvious as `control`, and also ensures it has a type
in the docs too. While here I also add a couple of extra links to make the
docs more inter-linked.
2023-04-21 07:38:42 +01:00
Will McGugan
cab4925eaa New CLI runner (#2338)
* New CLI runner

* runner functionality

* Add port

* use env for port

* changelog

* test fix

* flush

* remove constant

* comment

* tidy docs

* docstrings

* punctuation

* docstring

* fix test

* snapshot

* Update src/textual/cli/cli.py

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>

* guard against bad imports

* guard againsts screenshot

* always print return

* docstrings

* docstrings

---------

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
2023-04-20 17:09:39 +01:00
Dave Pearson
c8ecd26234 Merge pull request #2340 from davep/assorted-doc-tweaks
Assorted doc tweaks
2023-04-20 16:20:11 +01:00
Dave Pearson
d4f7ef02bb Merge pull request #2337 from davep/bug/2100/invisible-keys
Move default scroll navigation keys out of `Widget` and into `ScrollableContainer`
2023-04-20 15:37:45 +01:00
Dave Pearson
83da429793 Small collection of docstring tweaks 2023-04-20 14:13:56 +01:00
Dave Pearson
4801b3bc8f Link the doc for Checkbox.Changed.control to checkbox 2023-04-20 14:01:33 +01:00
Dave Pearson
8ea6658877 Link the doc for RadioButton.Changed.control to radio_button 2023-04-20 13:59:44 +01:00
Dave Pearson
84b5b866d4 Merge branch 'main' into bug/2100/invisible-keys 2023-04-20 13:45:30 +01:00
Dave Pearson
60542c52b3 Merge pull request #2339 from davep/refresh-all-the-screens
Ensure an app's CSS refresh updates all screens in the stack
2023-04-20 13:44:45 +01:00
Dave Pearson
61dc08dd99 Update the CHANGELOG 2023-04-20 11:42:14 +01:00
Dave Pearson
ae656c21c1 Refresh the CSS for all screens in an app's stack, when asked to refresh
Addresses #1999.
2023-04-20 11:39:12 +01:00
Dave Pearson
c507c4a785 Driveby typo fix
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
2023-04-20 11:14:11 +01:00
Dave Pearson
b6b8fbdb41 Fix typo
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
2023-04-20 11:13:01 +01:00
Dave Pearson
14f05899b2 Correct the location of the new items in the CHANGELOG
I'd accidentally started adding things under v0.20.1 rather than under a new
unreleased heading.
2023-04-20 10:09:20 +01:00
Dave Pearson
59e325d004 Update the CHANGELOG 2023-04-20 10:08:40 +01:00
Dave Pearson
1c5909eb23 Update the binding inheritance tests for the new moment bindings approach
Now that navigation bindings don't pollute the whole widget hierarchy any
more some of these tests can be tidied up.
2023-04-20 10:04:32 +01:00