Dave Pearson
da0f3911fb
Make Enter act as equals too
...
I suspect folk will hit enter when they mean = (see macOS calculator,
Windows calculator (I thin), etc...).
2022-10-20 13:40:15 +01:00
Dave Pearson
d7337c343e
Make the calculator example keyboard-friendly again
2022-10-20 13:38:54 +01:00
Will McGugan
b18842b46b
Merge pull request #962 from Textualize/binding-tuple-fix
...
Fix bindings as tuples
2022-10-19 17:23:51 +01:00
Darren Burns
f28cfec06e
Fix bindings as tuples
2022-10-19 16:41:29 +01:00
Will McGugan
48d59bb4fe
Merge pull request #961 from davep/bug/939/loss-of-focus-tidy-up
...
Post-PR #954 tidy up
2022-10-19 16:15:03 +01:00
Dave Pearson
76e9654535
Merge pull request #958 from davep/toll-free
...
Review the use of the bell in various examples and documentation files
2022-10-19 15:56:21 +01:00
Dave Pearson
7bbfd8ff87
Stop casting walk_children to a list
...
As of
b56fb018f1
2022-10-19 15:45:18 +01:00
darrenburns
3e46f5dbdd
Populate character on simulated key presses ( #960 )
...
* Populate character on simulated key presses
* Undo example
2022-10-19 15:42:54 +01:00
Dave Pearson
2e5e58e599
Don't check that a focusable widget can be focused
...
As per https://github.com/Textualize/textual/pull/954#discussion_r999501580
Good catch!
2022-10-19 15:42:11 +01:00
Dave Pearson
84e514e9e6
Merge pull request #954 from davep/bug/939/loss-of-focus-take-2
...
Try and better settle focus after a focused widget is removed (redux)
2022-10-19 15:35:23 +01:00
Dave Pearson
d4859495c6
Merge pull request #952 from davep/css-walk-children-listify
...
Modify DOMNode.walk_children to return a list
2022-10-19 15:33:45 +01:00
Dave Pearson
d22353d2ec
Correct the description of what the button example does
...
Originally it was partially correct in that it did sound the bell, but it
also then exited the application and printed the details of the button --
the text didn't mention the latter aspect. This corrects that and removes
mention of the bell sound because we've now removed that.
2022-10-19 15:28:15 +01:00
Dave Pearson
836a4e5291
Correct the file included for the second key example
...
Not an issue with removing the bell, actually a pre-existing mistake in the
docs. The wrong file was being included.
2022-10-19 15:24:44 +01:00
Dave Pearson
f648457c1e
action03 doesn't ring the bell on button press any more
2022-10-19 15:21:22 +01:00
Dave Pearson
6f93568f77
Remove the bell from the borders Textual CLI command
2022-10-19 15:19:41 +01:00
Dave Pearson
c4f920be67
Remove the bell from the Button documentation example
2022-10-19 15:15:53 +01:00
Dave Pearson
e8bb084538
Remove intro02.py
...
It doesn't appear to be referenced anywhere in the docs.
2022-10-19 15:12:54 +01:00
Dave Pearson
bd0e1c01b1
Remove intro01.py
...
It doesn't appear to be referenced anywhere in the docs.
2022-10-19 15:12:11 +01:00
Dave Pearson
f8bda04d90
Remove the on_space from key01 in the docs
...
While in this part of the docs we do want to keep the bell (see key02), it
was an error in the code that it included this event in key01. Removing it
from here because adding this bit of code for key02 is a key (no pun) part
of the docs.
2022-10-19 15:05:18 +01:00
Will McGugan
46a885cea7
Merge pull request #957 from Textualize/screens-dark
...
Fix variables in Screens, remove dark reactive from Screen
2022-10-19 15:01:43 +01:00
Dave Pearson
ce0c6c49a2
Remove the bell from the actions05 documentation example
2022-10-19 14:59:59 +01:00
Dave Pearson
f76e472096
Remove the bell from the actions04 documentation example
2022-10-19 14:57:50 +01:00
Dave Pearson
aa8580bee7
Remove the bell from the actions03 documentation example
2022-10-19 14:54:57 +01:00
Dave Pearson
5c5ca3316f
Remove the bell from the actions02 documentation example
2022-10-19 14:43:37 +01:00
Dave Pearson
f5ce603d43
Remove the bell from the actions01 documentation example
2022-10-19 14:41:13 +01:00
Dave Pearson
ae54db4f2a
Remove the bell from the calculator
...
Don't ping the terminal bell on every key-press. This might be okay on some
systems, on others (we're looking at you Windows) it's a wee bit
distracting.
See #955 .
2022-10-19 14:21:19 +01:00
Darren Burns
d0cfd1a000
Fix variables in Screens, remove dark reactive from Screen
2022-10-19 14:16:13 +01:00
Dave Pearson
11ddcdd771
Better settle focus when removing a focused widget
...
Addresses the issue raised in #939 . Here I rework Screen._reset_focus so
that, rather than deal with siblings, it deals with the focus chain. It now
also optionally takes a list of DOMNodes to avoid and will, as that
suggests, avoid them when looking for somewhere to move focus to.
As a preference the new version of this will seek to settle focus on the
nearest (in the chain) *previous* non-excluded DOMNode.
NOTE: Currently the return value of Widget.walk_children is cast to a list
to ensure that it doesn't get consumed (as of the time of commit, it's still
qan iterable). Once https://github.com/Textualize/textual/pull/952 has been
accepted I'll change this (remove the cast).
2022-10-19 12:55:43 +01:00
Dave Pearson
4a531dca6b
Rename buttons in removal tester
...
This makes it easier for me to see which widget is which in the focus chain,
etc, when logging.
2022-10-19 12:55:04 +01:00
Dave Pearson
78bb052ac7
Add sandbox code for testing work on #939
2022-10-19 10:45:23 +01:00
Dave Pearson
728d1a5454
Don't remove a widget from display before actual removal
...
This change ensures that, for example, the widget remains in the
Screen.focus_chain so that it's easier to handle passing off focus on
removal.
To help address #939 .
2022-10-19 10:44:44 +01:00
Dave Pearson
b56fb018f1
Modify DOMNode.walk_children to return a list
...
Originally it returned an iterable, building that up from a list anyway. In
local discussion it's been decided that it makes more sense to simply return
the list. There's no obvious advantage to doing it a different way.
2022-10-19 10:02:55 +01:00
Dave Pearson
4b3b622b35
Correct a comment typo
2022-10-19 10:02:31 +01:00
Will McGugan
586ffad1e5
Merge pull request #949 from aaronst/css
...
docs: remove center layout
2022-10-19 09:07:26 +01:00
Aaron Stephens
4111aa5432
docs: remove center layout
2022-10-18 15:51:23 -07:00
Dave Pearson
f4fafb447f
Merge pull request #938 from MatrixManAtYrService/patch-1
...
Minor doc fixes
2022-10-18 21:20:00 +01:00
darrenburns
e97b612e72
Ensure scroll events are forwarded to the screen ( #948 )
...
* Ensure scroll events are forwarded to the screen
* Small fix for scroll event forwarding
2022-10-18 16:11:34 +01:00
Will McGugan
0372c13d2b
removed prints
2022-10-18 15:25:49 +01:00
Will McGugan
9b22c6db9e
removed print statements
2022-10-18 15:25:04 +01:00
Will McGugan
8fd05f97aa
docstrings
2022-10-18 15:21:48 +01:00
darrenburns
4a0dc49bca
Checkbox polishing + fix auto-width in Horizontal layout ( #942 )
...
* checkbox widget
* fixes
* Checkbox additions, fix content width in horizontal layout
* Update docs, add tests for checkbox
* Remove some test code
* Small renaming of test class
Co-authored-by: Will McGugan <willmcgugan@gmail.com >
2022-10-18 15:17:44 +01:00
darrenburns
8c075561a2
Add support for action handlers prefixed with _ ( #946 )
2022-10-18 15:17:03 +01:00
Will McGugan
7ac3ad2439
Merge pull request #941 from Textualize/bindings-order
...
key bindings refactor
2022-10-18 15:16:54 +01:00
darrenburns
0f31cc4e45
Add directory of file to run to sys path ( #947 )
2022-10-18 15:16:46 +01:00
Will McGugan
87b6cbdc0a
Update src/textual/app.py
...
Co-authored-by: darrenburns <darrenburns@users.noreply.github.com >
2022-10-18 15:16:45 +01:00
Will McGugan
45b5d4af0a
remove allow forward
2022-10-18 15:00:37 +01:00
Will McGugan
f39e3f0420
added universal keys
2022-10-18 14:57:01 +01:00
Will McGugan
32d18a148f
swap order
2022-10-18 14:13:48 +01:00
Will McGugan
cee9d17b76
better typing
2022-10-18 14:08:33 +01:00
Will McGugan
5af46995dd
optimize check binding
2022-10-18 14:05:46 +01:00
