alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity
6,146 Commits 87 Branches 190 Tags
fcf9806f6b79b549633fa49e263415e794febcde
Commit Graph

6146 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dave Pearson
ae656c21c1 Refresh the CSS for all screens in an app's stack, when asked to refresh 
Addresses #1999.
 2023-04-20 11:39:12 +01:00
Dave Pearson
c507c4a785 Driveby typo fix 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-04-20 11:14:11 +01:00
Dave Pearson
b6b8fbdb41 Fix typo 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-04-20 11:13:01 +01:00
Dave Pearson
14f05899b2 Correct the location of the new items in the CHANGELOG 
I'd accidentally started adding things under v0.20.1 rather than under a new
unreleased heading.
 2023-04-20 10:09:20 +01:00
Dave Pearson
59e325d004 Update the CHANGELOG 2023-04-20 10:08:40 +01:00
Dave Pearson
1c5909eb23 Update the binding inheritance tests for the new moment bindings approach 
Now that navigation bindings don't pollute the whole widget hierarchy any
more some of these tests can be tidied up.
 2023-04-20 10:04:32 +01:00
Dave Pearson
8a909b0d0a Change all containers so they don't inherit bindings 
This is, to some degree, rendered moot by #2332, but for the moment it still
feels worth doing. The initial intention was to make sure that non-scrolling
containers and their child classes don't have bindings that may mask other
uses for navigation keys. However, it was realised that the "problem"
affected more than just containers (hence #2332).

But... on the off chance we add any more default bindings to
`Widget` (unlikely, but still), this will mean that they don't leak into the
containers unless we intend them to.

See #2331.
 2023-04-20 09:51:50 +01:00
Dave Pearson
7d82e30684 Fix demo so that keyboard navigation scrolls the display again 
The `Body` class inherited from `Container` rather than one of the scrolling
containers; until now it had worked because `Widget` provided the bindings
to make this happen, now that they've moved into `ScrollableContainer` that
stopped working.
 2023-04-20 09:42:29 +01:00
Dave Pearson
fe5f80bdd6 Change ScrollView to inherit from ScrollableContainer rather than Widget 
See #2332
 2023-04-20 09:40:58 +01:00
Dave Pearson
f4e5f23053 Merge pull request #2336 from davep/tidy-widget 
Remove unused import from widget.py
 2023-04-20 09:32:01 +01:00
Dave Pearson
ee45356c5c Update the CHANGELOG 2023-04-20 09:31:28 +01:00
Dave Pearson
49422932c7 Move scroll navigation key bindings out of widget and into own container 
The idea here is that not every widget will scroll, and as such not every
widget needs to have default bindings for calling the scrolling methods.
Generally scrolling is something done in a container.

These days we have *Scroll containers. As such it makes sense to introduce
the bindings in a common parent class for those containers.

This commit moves the binding from widget and creates that common parent
class, and then has HorizontalScroll and VerticalScroll inherit from it.

This is, it should be noted, a breaking change. Any code that creates a
scrolling widget that assumes that the bindings are just there, where that
widget doesn't inherit either from HorizontalScroll or VerticalScroll, will
suddenly find that scrolling with the keyboard is no longer possible.

See #2332.
 2023-04-20 09:15:05 +01:00
Dave Pearson
88b068fd64 Remove unused import from widget.py 2023-04-20 08:59:38 +01:00
Will McGugan
550cd47123 docstring 2023-04-19 17:13:57 +01:00
Will McGugan
d7f5fb9107 Fix frame rate limiter (#2318) 
* simplify

* fix for frame rate limiter

* fix update

* fix update

* update comment

* No need for lock

* remove comment

* fix for glitched test

* force update

* implement dim fix

* docstrings

* foreground fix

* cached filters

* cache default

* fix for filter tests

* docstring

* optimization

* Update src/textual/filter.py

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>

* Update src/textual/constants.py

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>

* fix cache

* remove comment [skip ci]

---------

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-04-19 16:55:42 +01:00
Dave Pearson
0e8e232a08 Merge pull request #2328 from davep/footer-cleanup 
Clean up various warnings in _footer.py
 2023-04-19 13:41:07 +01:00
Dave Pearson
f6612490df Clean up various warnings in _footer.py 
While visiting this for other reasons I noticed a number of warnings about
the code that were easy to tidy up. So I tidied them up.
 2023-04-19 13:27:10 +01:00
Will McGugan
81882fdf7d implement dim fix (#2326) 
* implement dim fix

* docstrings

* foreground fix

* cached filters

* cache default

* fix for filter tests

* docstring

* optimization

* Update src/textual/filter.py

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>

* Update src/textual/constants.py

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>

---------

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-04-19 13:24:31 +01:00
Dave Pearson
7c5203aa1b Merge pull request #2321 from davep/screen-results 
Add support for "returning" a result value from screens.
 2023-04-19 11:47:09 +01:00
Dave Pearson
768a235f3a Improve a docstring 
Co-authored-by: Will McGugan <willmcgugan@gmail.com>
 2023-04-19 11:40:34 +01:00
Dave Pearson
9123a80aa5 Update a screen instance's callback stack when it is switched out 
As per the observation here:

  https://github.com/Textualize/textual/pull/2321#pullrequestreview-1391744148
 2023-04-19 11:39:19 +01:00
Dave Pearson
5689e62230 Merge pull request #2325 from davep/private-event-handlers 
Make textual.widgets.* event handlers private
 2023-04-19 11:15:29 +01:00
Dave Pearson
5886c6bd0c Make DataTable event handlers private 
See #2324.
 2023-04-19 10:13:23 +01:00
Dave Pearson
36aa3321ff Make ToggleButton event handlers private 
See #2324.
 2023-04-19 10:07:36 +01:00
Dave Pearson
d23024141c Make Tabs event handlers private 
See #2324.
 2023-04-19 10:05:53 +01:00
Dave Pearson
1063c0f94c Make Switch event handlers private 
See #2324.
 2023-04-19 10:04:05 +01:00
Dave Pearson
d2c8206a8e Make RadioSet event handlers private 
See #2324.
 2023-04-19 10:02:47 +01:00
Dave Pearson
404d7b8fb8 Make PlaceHolder event handlers private 
See #2324.
 2023-04-19 09:53:56 +01:00
Dave Pearson
99d3c9fa79 Make OptionList event handlers private 
See #2324.
 2023-04-19 09:52:43 +01:00
Dave Pearson
da809ec717 Make Markdown event handlers private 
See #2324.
 2023-04-19 09:44:03 +01:00
Dave Pearson
6b147487bb Make LoadingIndicator event handlers private 
See #2324.
 2023-04-19 09:40:45 +01:00
Dave Pearson
489bcf3ad1 Make ListView event handlers private 
See #2324.
 2023-04-19 09:39:36 +01:00
Dave Pearson
f9071987bd Make ListItem event handlers private 
See #2324.
 2023-04-19 09:37:35 +01:00
Will McGugan
db1b784606 dim filter (#2323) 
* dim filter

* optimization

* Remove test code

* move functions out of filter

* docstring

* move function to module scope

* docstring

* docstrings
 2023-04-19 09:31:59 +01:00
Dave Pearson
18a6428738 Make Input event handlers private 
See #2324.
 2023-04-19 09:30:44 +01:00
Dave Pearson
c9664f0ff5 Make Header event handlers private 
See #2324.
 2023-04-19 09:20:10 +01:00
Dave Pearson
69477c2a18 Make DirectoryTree event handlers private 
See #2324.
 2023-04-19 09:17:01 +01:00
Dave Pearson
590c898213 Make ContentSwitcher.on_mount private 
See #2324.
 2023-04-19 09:13:28 +01:00
Will McGugan
4981effcba Revert "Prevent reactive-watcher loop in Tabs / TabbedContent." (#2322) 
* Revert "Prevent reactive-watcher loop in Tabs / TabbedContent. (#2305)"

This reverts commit 66a644845b.

* fix stuck tab

* fix for stuck underline

* snpshot
v0.20.1 		2023-04-18 16:46:10 +01:00
Dave Pearson
c9dd89b944 Merge branch 'main' into screen-results 2023-04-18 14:29:40 +01:00
Will McGugan
cc41a7f81d Bump0200 (#2320) 
* version bump

* changelog
v0.20.0 		2023-04-18 13:41:15 +01:00
Will McGugan
bbe38f7d30 faq entry on Transparent backgrounds (#2319) 
* faq entry

* word

* update to words
 2023-04-18 13:29:13 +01:00
Dave Pearson
e3babfd812 Drop dismiss_with 
Just go with a single dismiss method.
 2023-04-18 13:11:51 +01:00
Dave Pearson
21783fb479 Fix the typing for ResultCallback.__init__ 2023-04-18 12:49:28 +01:00
Dave Pearson
2e7b010301 Allow for a screen being pushed when the stack is empty 
Under normal circumstances the code wouldn't encounter this problem as
there's always a default screen; but a handful of tests that were testing
the screen stack broke after the recent additions relating to result
callbacks.

This cleans up that problem.
 2023-04-18 11:54:32 +01:00
Rodrigo Girão Serrão
66a644845b Prevent reactive-watcher loop in Tabs / TabbedContent. (#2305) 
* Add regression test for #2229.

* Fix potential reactive-watch loop.

* Simplify regression test.

Labels are cheaper to use and the final visual result of the test won't depend on the directory it runs from.

* Simplify solution.

Turns out I didn't need a descriptor. :(

* Fail on empty tab.
 2023-04-18 11:48:33 +01:00
Rodrigo Girão Serrão
3a7cf08ef2 Make scrollable containers focusable. (#2317) 
* Make scrollable containers focusable.

Related issues: #2270.
 2023-04-18 11:44:32 +01:00
Dave Pearson
77e47f7508 Swap the result callbacks on screens to be a stack of callbacks 
It is possible for the same instance of a screen to get pushed onto the
screen stack multiple times; as such we really need to keep track of all the
callback requests.

So here I register a callback for every screen push and clean it up on every
screen pop; with those without callbacks being no-ops.
 2023-04-18 11:40:12 +01:00
darrenburns
496f8b4524 Updating styles on demand instead of on_idle (#2304) 
* Updating styles on demand instead of on_idle

* Tidy up update_styles

* Fix LRU cache tests

* Remove some debugging code

* Adding test for pseudoclass style update

* Update changelog
 2023-04-18 11:36:00 +01:00
Rodrigo Girão Serrão
01d67173e8 Don't expose snippets publically. (#2300) 2023-04-18 10:19:43 +01:00